Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix dev shell: upgrade fourmolu-0.18.0 #744

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Nix dev shell: upgrade fourmolu-0.18.0 #744

wants to merge 3 commits into from
+292 −283

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 31, 2025 •
edited
Loading

Changelog

- description: |
    Nix dev shell: upgrade fourmolu-0.18.0
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Reformat codebase with the new version.

Fourmolu 0.18 supports import grouping but there's no column-wise alignment yet, so we're still keeping stylish haskell around for formatting imports.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Jan 31, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/upgrade-fourmolu-0.18 branch 2 times, most recently from f1068be to 489fd73 Compare February 3, 2025 14:39
@carbolymer carbolymer marked this pull request as ready for review February 3, 2025 14:39
@carbolymer carbolymer force-pushed the mgalazyn/chore/upgrade-fourmolu-0.18 branch from 489fd73 to c068294 Compare February 3, 2025 14:48
smelc
smelc reviewed Feb 3, 2025
View reviewed changes
.git-blame-ignore-revs
@@ -1,2 +1,3 @@
e28fadbebc18b87991f84af72d8611393ae8875a
b76f949e815990545371530a466b16f691a3aa98
73fd9122f78282b1db7f6884b3bc23fb29f3e67f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😉

smelc
smelc approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but be careful to update .git-blame-ignore-revs when you rebase 🙂

@carbolymer carbolymer added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@carbolymer carbolymer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carbolymer @smelc